Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(install): auto set the default time zone to where the server is located #1304

Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat(install): auto set the default time zone to where the server is located #1304

merged 1 commit into from
Apr 11, 2025
+60 −2

Conversation

hgaol
Copy link
Member

@hgaol hgaol commented Apr 2, 2025

Close #1303

@LinkinStars LinkinStars self-requested a review April 2, 2025 14:31
@LinkinStars LinkinStars self-assigned this Apr 2, 2025
LinkinStars
LinkinStars approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@LinkinStars LinkinStars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long review. I've been looking for a way to do this without enumerating all the timezone constants, but haven't found a more elegant solution yet. I'll merge this PR for now and if there's a better way I'll do a replacement.

@LinkinStars LinkinStars merged commit 840f6bf into apache:dev Apr 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@LinkinStars LinkinStars LinkinStars approved these changes

Assignees

@LinkinStars LinkinStars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hgaol @LinkinStars